Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(ci): pin uv to 0.2.10" #3874

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jun 13, 2024

Reverts #3870

Summary by CodeRabbit

  • Chores
    • Updated build workflow to remove the specific version number from the curl command in the "Install uv" job.

Copy link
Contributor

coderabbitai bot commented Jun 13, 2024

Walkthrough

Walkthrough

The .github/workflows/build_wheel.yml file has been updated to simplify the installation process of the uv tool by removing the specific version number from the curl command URL, allowing for more flexibility in obtaining the latest available version.

Changes

Files Change Summary
.github/workflows/build_wheel.yml Modified curl command in the "Install uv" job to remove the specific version number from the URL.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a1a3840 and 1b96712.

Files selected for processing (1)
  • .github/workflows/build_wheel.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/build_wheel.yml (1)

78-78: Ensure the dynamic fetching of the uv package version is intended.

This change aligns with the PR objective to revert the uv version pinning. However, it's crucial to monitor the impact of using potentially different uv versions in future builds to avoid unexpected behavior.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.70%. Comparing base (a1a3840) to head (1b96712).
Report is 117 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3874   +/-   ##
=======================================
  Coverage   82.70%   82.70%           
=======================================
  Files         517      517           
  Lines       50141    50141           
  Branches     2984     2984           
=======================================
  Hits        41469    41469           
  Misses       7762     7762           
  Partials      910      910           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz requested a review from wanghan-iapcm June 13, 2024 08:45
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Jun 13, 2024
Merged via the queue into devel with commit ed5a2e4 Jun 13, 2024
109 checks passed
@njzjz njzjz deleted the revert-3870-pin-uv-0.2.6 branch June 13, 2024 21:54
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this pull request Sep 18, 2024
Reverts deepmodeling#3870

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated build workflow to remove the specific version number from the
`curl` command in the "Install uv" job.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants