fix(pt): improve out-of-memory capture

[njzjz]

I just received another error message that reports out of memory. It's a bad design of PyTorch that all errors use a general RuntimeError.

Summary by CodeRabbit

• Bug Fixes
  • Improved out-of-memory error detection for CUDA driver issues.

[coderabbitai]

Walkthrough

Walkthrough

The is_oom_error function in the auto_batch_size.py file within the deepmd/pt/utils module has been enhanced. It now includes a new condition to check for a specific CUDA driver error message related to out-of-memory situations, improving the function's ability to detect memory issues.

Changes

Files	Change Summary
deepmd/pt/utils/auto_batch_size.py	Updated is_oom_error function to include a new condition for a specific CUDA driver error message related to out-of-memory situations.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant auto_batch_size.py
    participant CUDA Driver

    User->>auto_batch_size.py: Call is_oom_error(error_message)
    auto_batch_size.py->>auto_batch_size.py: Check for existing OOM conditions
    auto_batch_size.py-->>auto_batch_size.py: Check for new CUDA OOM condition
    auto_batch_size.py-->>User: Return True/False based on OOM condition

Loading

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 674bad7 and 325d32c.

Files selected for processing (1)

• deepmd/pt/utils/auto_batch_size.py (1 hunks)

Additional comments not posted (4)

deepmd/pt/utils/auto_batch_size.py (4)

60-60: Enhanced detection of out-of-memory errors.

Consider adding logging before clearing the cache to help with debugging and monitoring.

---

60-60: Complex batch processing logic appears robust and well-handled.

---

60-60: Standard method for checking GPU availability.

---

60-60: Constructor uses sensible defaults and proper delegation.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.66%. Comparing base (674bad7) to head (325d32c).
Report is 116 commits behind head on devel.

Additional details and impacted files

@@           Coverage Diff           @@
##            devel    #3857   +/-   ##
=======================================
  Coverage   82.66%   82.66%           
=======================================
  Files         517      517           
  Lines       49724    49724           
  Branches     2984     2984           
=======================================
  Hits        41105    41105           
  Misses       7709     7709           
  Partials      910      910           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.