-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pt/tf/dp): support econf type embedding #3781
Conversation
Warning Rate Limit Exceeded@iProzd has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 3 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThis update introduces support for electronic configuration type embedding (econf_tebd) across various modules in the deepmd library. Key changes include adding Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@@ -127,6 +131,7 @@ | |||
smooth_type_embedding, | |||
concat_output_tebd, | |||
precision, | |||
use_econf_tebd, |
Check notice
Code scanning / CodeQL
Unused local variable Note test
@@ -150,6 +155,7 @@ | |||
smooth_type_embedding, | |||
concat_output_tebd, | |||
precision, | |||
use_econf_tebd, |
Check notice
Code scanning / CodeQL
Unused local variable Note test
@@ -240,6 +247,7 @@ | |||
smooth_type_embedding, | |||
concat_output_tebd, | |||
precision, | |||
use_econf_tebd, |
Check notice
Code scanning / CodeQL
Unused local variable Note test
@@ -173,6 +177,7 @@ | |||
exclude_types, | |||
precision, | |||
add_tebd_to_repinit_out, | |||
use_econf_tebd, |
Check notice
Code scanning / CodeQL
Unused local variable Note test
@@ -200,6 +205,7 @@ | |||
exclude_types, | |||
precision, | |||
add_tebd_to_repinit_out, | |||
use_econf_tebd, |
Check notice
Code scanning / CodeQL
Unused local variable Note test
@@ -227,6 +233,7 @@ | |||
exclude_types, | |||
precision, | |||
add_tebd_to_repinit_out, | |||
use_econf_tebd, |
Check notice
Code scanning / CodeQL
Unused local variable Note test
@@ -290,6 +297,7 @@ | |||
exclude_types, | |||
precision, | |||
add_tebd_to_repinit_out, | |||
use_econf_tebd, |
Check notice
Code scanning / CodeQL
Unused local variable Note test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 8
Out of diff range and nitpick comments (2)
deepmd/tf/utils/type_embed.py (1)
103-107
: Add documentation for the new parameters.The new parameters
use_econf_tebd
andtype_map
are documented correctly. Ensure that the documentation is consistent with the rest of the project.deepmd/pt/model/descriptor/dpa1.py (1)
175-179
: Document the default values foruse_econf_tebd
andtype_map
.For better clarity, mention the default values of
use_econf_tebd
andtype_map
in the docstring.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3781 +/- ##
==========================================
+ Coverage 82.49% 82.50% +0.01%
==========================================
Files 515 515
Lines 48642 48712 +70
Branches 2980 2980
==========================================
+ Hits 40126 40192 +66
- Misses 7605 7609 +4
Partials 911 911 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Co-authored-by: Han Wang <92130845+wanghan-iapcm@users.noreply.github.com> Signed-off-by: Duo <50307526+iProzd@users.noreply.github.com>
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced `use_econf_tebd` and `type_map` parameters for advanced electronic configuration type embedding. - Enhanced serialization to support new parameters. - **Bug Fixes** - Improved handling of type embedding configurations to ensure consistency. - **Documentation** - Updated documentation to include new parameters and their usage. These updates provide more flexibility and control over electronic configuration type embedding, enhancing the model's configurability and performance. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Duo <50307526+iProzd@users.noreply.github.com> Co-authored-by: Han Wang <92130845+wanghan-iapcm@users.noreply.github.com>
Summary by CodeRabbit
New Features
use_econf_tebd
andtype_map
parameters for advanced electronic configuration type embedding.Bug Fixes
Documentation
These updates provide more flexibility and control over electronic configuration type embedding, enhancing the model's configurability and performance.