fix: set rpath for libtorch and protobuf #3636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3636 +/- ##
==========================================
+ Coverage 77.80% 77.94% +0.14%
==========================================
Files 438 404 -34
Lines 37707 32876 -4831
Branches 1623 909 -714
==========================================
- Hits 29337 25626 -3711
+ Misses 7506 6722 -784
+ Partials 864 528 -336 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
njzjz
changed the title
|
cc: @Yi-FanLi |
wanghan-iapcm
approved these changes
Apr 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Jun 20, 2024
The previous `PyTorch_LIBRARY_PATH` in deepmodeling#3636 is wrong: `BACKEND_INCLUDE_DIRS` is a list of paths instead of a single path. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
The previous `PyTorch_LIBRARY_PATH` in #3636 is wrong: `BACKEND_INCLUDE_DIRS` is a list of paths instead of a single path. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved the method for retrieving the PyTorch library path during the build process to enhance configuration accuracy. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Jul 2, 2024
Fix deepmodeling#3568. Set run path for libtorch and protobuf. Refactor the original `TensorFlow_LIBRARY_PATH` to `BACKEND_LIBRARY_PATH` (list). --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> (cherry picked from commit 4c546d0) Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Merged
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Jul 12, 2024
There is a typo in deepmodeling#3636 Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 13, 2024
There was a typo in #3636. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated build configuration to improve compatibility with PyTorch by modifying library path settings. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
mtaillefumier
pushed a commit
to mtaillefumier/deepmd-kit
that referenced
this pull request
Sep 18, 2024
The previous `PyTorch_LIBRARY_PATH` in deepmodeling#3636 is wrong: `BACKEND_INCLUDE_DIRS` is a list of paths instead of a single path. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved the method for retrieving the PyTorch library path during the build process to enhance configuration accuracy. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
mtaillefumier
pushed a commit
to mtaillefumier/deepmd-kit
that referenced
this pull request
Sep 18, 2024
There was a typo in deepmodeling#3636. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated build configuration to improve compatibility with PyTorch by modifying library path settings. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3568.
Set run path for libtorch and protobuf. Refactor the original
TensorFlow_LIBRARY_PATHtoBACKEND_LIBRARY_PATH(list).