Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix type hint of sel #3624

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Mar 30, 2024

The wrong type hint appeared in f5c67af, very old...

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.70%. Comparing base (cc30f27) to head (e289fee).

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3624   +/-   ##
=======================================
  Coverage   77.70%   77.70%           
=======================================
  Files         437      437           
  Lines       37566    37566           
  Branches     1623     1623           
=======================================
  Hits        29189    29189           
  Misses       7513     7513           
  Partials      864      864           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Mar 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 30, 2024
@njzjz njzjz added this pull request to the merge queue Mar 30, 2024
Merged via the queue into deepmodeling:devel with commit d0d5a94 Mar 30, 2024
49 checks passed
@njzjz njzjz deleted the fix-sel-type-hint branch March 30, 2024 20:04
@njzjz njzjz mentioned this pull request Apr 2, 2024
@njzjz njzjz added this to the v2.2.10 milestone Apr 6, 2024
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Apr 6, 2024
The wrong type hint appeared in
f5c67af, very old...

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
(cherry picked from commit d0d5a94)
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz mentioned this pull request Apr 6, 2024
njzjz added a commit that referenced this pull request Apr 6, 2024
The wrong type hint appeared in
f5c67af, very old...

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
(cherry picked from commit d0d5a94)
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants