Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mask to atomic model output when an atomic type exclusion presents. #3389

Merged
merged 2 commits into from
Mar 2, 2024

Conversation

wanghan-iapcm
Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm commented Mar 2, 2024

This PR also

  • introduce atomic_output_def used wraps the fitting_output_def.
  • atomic_output_def will be used by make_model
  • add missing ut for pair and atom exclusions in dpmodel

See also #3357

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 76.60%. Comparing base (f4abe12) to head (4d21d0d).
Report is 6 commits behind head on devel.

Files Patch % Lines
...pmd/dpmodel/atomic_model/make_base_atomic_model.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3389      +/-   ##
==========================================
+ Coverage   76.57%   76.60%   +0.02%     
==========================================
  Files         420      420              
  Lines       35682    35749      +67     
  Branches     1620     1620              
==========================================
+ Hits        27323    27384      +61     
- Misses       7491     7497       +6     
  Partials      868      868              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iProzd iProzd added this pull request to the merge queue Mar 2, 2024
Merged via the queue into deepmodeling:devel with commit cbeb1d5 Mar 2, 2024
48 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants