Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent deepmd.tf be imported globally #3382

Merged
merged 2 commits into from
Mar 2, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Mar 2, 2024

Add a ruff rule TID253 to ensure it.

Add a ruff rule `TID253` to ensure it.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.57%. Comparing base (ee8b82b) to head (6d2a334).

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3382   +/-   ##
=======================================
  Coverage   76.57%   76.57%           
=======================================
  Files         420      420           
  Lines       35683    35683           
  Branches     1620     1620           
=======================================
  Hits        27323    27323           
  Misses       7492     7492           
  Partials      868      868           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz changed the title fix: prevent deepmd.tf to be imported globally fix: prevent deepmd.tf be imported globally Mar 2, 2024
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Mar 2, 2024
Merged via the queue into deepmodeling:devel with commit 831610a Mar 2, 2024
48 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants