Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge change_energy_bias and fix finetune #3378

Merged
merged 56 commits into from
Mar 3, 2024
Merged

Conversation

iProzd
Copy link
Collaborator

@iProzd iProzd commented Mar 1, 2024

No description provided.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 88.75000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 76.90%. Comparing base (4f933d8) to head (dd50237).

Files Patch % Lines
deepmd/utils/finetune.py 88.13% 7 Missing ⚠️
deepmd/pt/model/task/fitting.py 94.44% 1 Missing ⚠️
deepmd/pt/utils/finetune.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3378      +/-   ##
==========================================
+ Coverage   76.69%   76.90%   +0.21%     
==========================================
  Files         421      422       +1     
  Lines       35838    35825      -13     
  Branches     1620     1620              
==========================================
+ Hits        27486    27552      +66     
+ Misses       7484     7405      -79     
  Partials      868      868              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you validate that the change_energy_bias works as you want? How is it covered by UT?

@njzjz njzjz added this pull request to the merge queue Mar 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 3, 2024
iProzd and others added 2 commits March 3, 2024 12:43
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz enabled auto-merge March 3, 2024 05:12
@njzjz njzjz added this pull request to the merge queue Mar 3, 2024
Merged via the queue into deepmodeling:devel with commit c31d376 Mar 3, 2024
48 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
@iProzd iProzd deleted the finetune_rf branch April 24, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants