fix: cast input and output types at model's interface #3352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+242
to
+247
| # for vv, kk in zip([fparam, aparam], ["frame", "atomic"]): | ||
| # if vv is not None and self.reverse_precision_dict[vv.dtype] != input_prec: | ||
| # log.warning( | ||
| # f"type of {kk} parameter {self.reverse_precision_dict[vv.dtype]}" | ||
| # " does not match" | ||
| # f" that of the coordinate {input_prec}" |
Check notice
Code scanning / CodeQL
Commented-out code Note
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3352 +/- ##
==========================================
+ Coverage 75.85% 75.87% +0.02%
==========================================
Files 416 416
Lines 34908 34975 +67
Branches 1614 1614
==========================================
+ Hits 26480 26538 +58
- Misses 7560 7569 +9
Partials 868 868 ☔ View full report in Codecov by Sentry. |
njzjz
approved these changes
Feb 28, 2024
njzjz
requested changes
Feb 28, 2024
CaRoLZhangxy
approved these changes
Feb 28, 2024
added 2 commits
February 29, 2024 00:09
njzjz
approved these changes
Feb 28, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.