Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: se_r prod_env_mat #3351

Merged
merged 6 commits into from
Feb 28, 2024
Merged

Fix: se_r prod_env_mat #3351

merged 6 commits into from
Feb 28, 2024

Conversation

anyangml
Copy link
Collaborator

This should fix the bug.
image

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.69%. Comparing base (004ebd6) to head (06407b2).

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3351      +/-   ##
==========================================
+ Coverage   75.64%   75.69%   +0.04%     
==========================================
  Files         411      411              
  Lines       34569    34574       +5     
  Branches     1599     1603       +4     
==========================================
+ Hits        26151    26171      +20     
+ Misses       7558     7543      -15     
  Partials      860      860              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test to cover the line you added?

@njzjz njzjz linked an issue Feb 28, 2024 that may be closed by this pull request
@anyangml anyangml requested a review from njzjz February 28, 2024 04:54
@anyangml anyangml added this pull request to the merge queue Feb 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 28, 2024
@anyangml anyangml added this pull request to the merge queue Feb 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 28, 2024
@anyangml anyangml added this pull request to the merge queue Feb 28, 2024
Merged via the queue into deepmodeling:devel with commit fd17e2e Feb 28, 2024
48 checks passed
@anyangml anyangml deleted the devel branch February 28, 2024 07:48
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] pt se_e2_r failed to do env mat stat
2 participants