fix_dplr.cpp set atom->image when pre_force #3345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3345 +/- ##
=======================================
Coverage 75.55% 75.55%
=======================================
Files 408 408
Lines 34246 34247 +1
Branches 1604 1604
=======================================
+ Hits 25875 25876 +1
Misses 7510 7510
Partials 861 861 ☔ View full report in Codecov by Sentry. |
Yi-FanLi
approved these changes
Feb 27, 2024
Closed
njzjz
pushed a commit
to njzjz/deepmd-kit
that referenced
this pull request
Apr 6, 2024
The atom->image of the wannier centroid should be set to the same as its real counterpart when assigning the position. --------- Co-authored-by: Yifan Li李一帆 <yifanl0716@gmail.com> (cherry picked from commit b1de9e6)
Merged
njzjz
pushed a commit
that referenced
this pull request
Apr 6, 2024
The atom->image of the wannier centroid should be set to the same as its real counterpart when assigning the position. --------- Co-authored-by: Yifan Li李一帆 <yifanl0716@gmail.com> (cherry picked from commit b1de9e6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The atom->image of the wannier centroid should be set to the same as its real counterpart when assigning the position.