Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add BaseModel; store type in serialization #3335

Merged
merged 17 commits into from
Feb 27, 2024
Merged

add BaseModel; store type in serialization #3335

merged 17 commits into from
Feb 27, 2024

Commits on Feb 25, 2024

  1. basemodel; store type 

    Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
    @njzjz
    njzjz committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    b374abc View commit details
    Browse the repository at this point in the history

  2. use DeepEval 

    Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
    @njzjz
    njzjz committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    325ff74 View commit details
    Browse the repository at this point in the history

  3. fix DPModel.__new__ 

    Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
    @njzjz
    njzjz committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    99dbc7b View commit details
    Browse the repository at this point in the history

  4. fallback to DPModel 

    Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
    @njzjz
    njzjz committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    7fbaf71 View commit details
    Browse the repository at this point in the history

  5. Update deepmd/dpmodel/model/base_model.py 

    Co-authored-by: Han Wang <92130845+wanghan-iapcm@users.noreply.github.com>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
    @njzjz @wanghan-iapcm
    njzjz and wanghan-iapcm authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    c2fb0be View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Han Wang <92130845+wanghan-iapcm@users.noreply.github.com>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
    @njzjz @wanghan-iapcm
    njzjz and wanghan-iapcm authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    7af6ce3 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'devel' into basemodel

    @njzjz
    njzjz committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    fd455b7 View commit details
    Browse the repository at this point in the history

  8. fix indent 

    Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
    @njzjz
    njzjz committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    1fe4def View commit details
    Browse the repository at this point in the history

  9. combine deserialize 

    Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
    @njzjz
    njzjz committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    74c4116 View commit details
    Browse the repository at this point in the history

  10. fix typo 

    Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
    @njzjz
    njzjz committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    ffc7dfc View commit details
    Browse the repository at this point in the history

  11. use self as type hint 

    Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
    @njzjz
    njzjz committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    054fba6 View commit details
    Browse the repository at this point in the history

  12. Revert "use self as type hint" 

    This reverts commit 054fba6.
    @njzjz
    njzjz committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    2f9d56f View commit details
    Browse the repository at this point in the history

  13. add serialize 

    Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
    @njzjz
    njzjz committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    4a17c1f View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Apply suggestions from code review 

    Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
    @njzjz
    njzjz authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    9681276 View commit details
    Browse the repository at this point in the history

  2. add make_base_model 

    Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
    @njzjz
    njzjz committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    67b83ed View commit details
    Browse the repository at this point in the history

  3. fix error message 

    Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
    @njzjz
    njzjz committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    fbd1300 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. move get_model_def_script to make_base_atomic_model 

    Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
    @njzjz
    njzjz committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    d3ef0a4 View commit details
    Browse the repository at this point in the history