Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store type in fitting serialization data #3331

Merged
merged 3 commits into from
Feb 24, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Feb 24, 2024

No description provided.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 95.74468% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 75.43%. Comparing base (649fdca) to head (d537969).

Files Patch % Lines
deepmd/dpmodel/fitting/make_base_fitting.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3331      +/-   ##
==========================================
+ Coverage   75.41%   75.43%   +0.02%     
==========================================
  Files         406      406              
  Lines       34106    34131      +25     
  Branches     1604     1604              
==========================================
+ Hits        25720    25747      +27     
+ Misses       7525     7523       -2     
  Partials      861      861              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz marked this pull request as draft February 24, 2024 04:20
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz marked this pull request as ready for review February 24, 2024 07:06
@njzjz njzjz requested a review from wanghan-iapcm February 24, 2024 07:06
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Feb 24, 2024
Merged via the queue into deepmodeling:devel with commit 91049df Feb 24, 2024
48 checks passed
@njzjz njzjz linked an issue Mar 1, 2024 that may be closed by this pull request
3 tasks
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serialize should contain type information
2 participants