Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit.ci] pre-commit autoupdate #3305

Merged
merged 3 commits into from
Feb 20, 2024
Merged

[pre-commit.ci] pre-commit autoupdate #3305

merged 3 commits into from
Feb 20, 2024

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Feb 19, 2024

@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
563ab47 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.2.1 → v0.2.2](astral-sh/ruff-pre-commit@v0.2.1...v0.2.2)
- [github.com/Lucas-C/pre-commit-hooks: v1.5.4 → v1.5.5](Lucas-C/pre-commit-hooks@v1.5.4...v1.5.5)
@codecov Codecov
Copy link

codecov bot commented Feb 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab35468) 75.05% compared to head (59501ea) 75.05%.
Report is 1 commits behind head on devel.

Additional details and impacted files 
@@           Coverage Diff           @@
##            devel    #3305   +/-   ##
=======================================
  Coverage   75.05%   75.05%           
=======================================
  Files         396      396           
  Lines       33895    33895           
  Branches     1604     1604           
=======================================
  Hits        25441    25441           
  Misses       7593     7593           
  Partials      861      861

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz
Copy link
Member

njzjz commented Feb 20, 2024 

source/tests/common/dpmodel/test_neighbor_stat.py:19:22: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/common/dpmodel/test_neighbor_stat.py:23:24: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/pt/model/test_force_grad.py:92:25: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/pt/test_neighbor_stat.py:19:22: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/pt/test_neighbor_stat.py:23:24: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_data_modifier_shuffle.py:108:24: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_data_modifier_shuffle.py:109:25: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_deepmd_data.py:40:22: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_deepmd_data.py:46:20: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_deepmd_data.py:96:22: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_deepmd_data.py:102:26: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_deepmd_data.py:109:26: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_deepmd_data.py:116:20: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_deepmd_data.py:120:24: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_deepmd_data.py:124:24: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_deepmd_data.py:128:28: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_deepmd_data.py:135:27: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_deepmd_data.py:138:31: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_deepmd_data_sys.py:43:23: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_deepmd_data_sys.py:46:23: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_deepmd_data_sys.py:49:23: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_descrpt_sea_ef_rot.py:100:18: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_descrpt_sea_ef_rot.py:114:19: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_ewald.py:41:20: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_ewald.py:45:21: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_ewald.py:50:23: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_gen_stat_data.py:28:22: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_gen_stat_data.py:29:22: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_gen_stat_data.py:30:21: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_gen_stat_data.py:31:24: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_neighbor_stat.py:19:22: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
source/tests/tf/test_neighbor_stat.py:23:24: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
Found 32 errors.

@njzjz
replace np.random.random with np.random.default_rng().random
9a5a975 
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz
extra file
59501ea 
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz enabled auto-merge February 20, 2024 02:19
@njzjz njzjz added this pull request to the merge queue Feb 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2024
@njzjz
Copy link
Member

njzjz commented Feb 20, 2024

Record the GPU errors (not related to this PR):

=========================== short test summary info ============================
FAILED source/tests/tf/test_model_compression_se_atten.py::TestDeepPotAPBC::test_1frame - AssertionError: 
Arrays are not almost equal to 3 decimals

Mismatched elements: 1 / 9 (11.1%)
Max absolute difference: 0.00151662
Max relative difference: 0.00233575
 x: array([[ 0.69 ,  0.192, -0.44 ,  0.192,  0.362, -0.378, -0.44 , -0.378,
         0.694]])
 y: array([[ 0.691,  0.193, -0.441,  0.193,  0.363, -0.379, -0.441, -0.379,
         0.695]])
FAILED source/tests/tf/test_model_compression_se_atten.py::TestDeepPotAPBC::test_1frame_atm - AssertionError: 
Arrays are not almost equal to 3 decimals

Mismatched elements: 1 / 9 (11.1%)
Max absolute difference: 0.00151662
Max relative difference: 0.00233575
 x: array([[ 0.69 ,  0.192, -0.44 ,  0.192,  0.362, -0.378, -0.44 , -0.378,
         0.694]])
 y: array([[ 0.691,  0.193, -0.441,  0.193,  0.363, -0.379, -0.441, -0.379,
         0.695]])
FAILED source/tests/tf/test_model_compression_se_atten.py::TestDeepPotAPBC::test_2frame_atm - AssertionError: 
Arrays are not almost equal to 3 decimals

Mismatched elements: 2 / 18 (11.1%)
Max absolute difference: 0.00151662
Max relative difference: 0.00233575
 x: array([[ 0.69 ,  0.192, -0.44 ,  0.192,  0.362, -0.378, -0.44 , -0.378,
         0.694],
       [ 0.69 ,  0.192, -0.44 ,  0.192,  0.362, -0.378, -0.44 , -0.378,
         0.694]])
 y: array([[ 0.691,  0.193, -0.441,  0.193,  0.363, -0.379, -0.441, -0.379,
         0.695],
       [ 0.691,  0.193, -0.441,  0.193,  0.363, -0.379, -0.441, -0.379,
         0.695]])
==== 3 failed, 743 passed, 113 skipped, 206 warnings in 1403.73s (0:23:23) =====

@njzjz njzjz added this pull request to the merge queue Feb 20, 2024
Merged via the queue into devel with commit 4b994df Feb 20, 2024
82 checks passed
@njzjz njzjz deleted the pre-commit-ci-update-config branch February 20, 2024 04:50
@njzjz njzjz mentioned this pull request Apr 2, 2024
Closed
@njzjz njzjz added this to the v2.2.10 milestone Apr 6, 2024
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Apr 6, 2024
@pre-commit-ci @njzjz
[pre-commit.ci] pre-commit autoupdate (deepmodeling#3305)
ba81a00 
<!--pre-commit.ci start-->
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.2.1 →
v0.2.2](astral-sh/ruff-pre-commit@v0.2.1...v0.2.2)
- [github.com/Lucas-C/pre-commit-hooks: v1.5.4 →
v1.5.5](Lucas-C/pre-commit-hooks@v1.5.4...v1.5.5)
<!--pre-commit.ci end-->

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
(cherry picked from commit 4b994df)
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz mentioned this pull request Apr 6, 2024
Merged
njzjz added a commit that referenced this pull request Apr 6, 2024
@pre-commit-ci @njzjz
[pre-commit.ci] pre-commit autoupdate (#3305)
9ac2f93 
<!--pre-commit.ci start-->
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.2.1 →
v0.2.2](astral-sh/ruff-pre-commit@v0.2.1...v0.2.2)
- [github.com/Lucas-C/pre-commit-hooks: v1.5.4 →
v1.5.5](Lucas-C/pre-commit-hooks@v1.5.4...v1.5.5)
<!--pre-commit.ci end-->

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
(cherry picked from commit 4b994df)
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njzjz njzjz njzjz approved these changes

Assignees
No one assigned
Labels
Python
Projects
None yet
Milestone
v2.2.10
Development

Successfully merging this pull request may close these issues.
1 participant
@njzjz