Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hessian autodiff calculation #3262

Merged
merged 10 commits into from
Feb 14, 2024

Conversation

wanghan-iapcm
Copy link
Collaborator

restrictions:

  • cannot jit
  • only the forward_common interface has its hessian calculation. not for forward_common_lower.
  • may give nan when nall == nloc. specifically when nloc==1

also fix bug in pt: transform_output. The output shape will be wrong when the dimension of output variable is larger than 1.

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c131c8f) 75.27% compared to head (7ac6d31) 74.91%.
Report is 9 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3262      +/-   ##
==========================================
- Coverage   75.27%   74.91%   -0.37%     
==========================================
  Files         373      378       +5     
  Lines       33227    33351     +124     
  Branches     1605     1600       -5     
==========================================
- Hits        25012    24985      -27     
- Misses       7344     7495     +151     
  Partials      871      871              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm enabled auto-merge (squash) February 14, 2024 08:13
@wanghan-iapcm wanghan-iapcm merged commit 25bf37a into deepmodeling:devel Feb 14, 2024
46 checks passed
@wanghan-iapcm wanghan-iapcm deleted the hessian-1 branch February 14, 2024 08:48
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants