Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt: apply global logger to pt #3222

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Feb 3, 2024

We can change the format of the global logger in the future if the additional information is helpful (e.g., time, path, etc).

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (677d936) 74.78% compared to head (2333b4c) 74.78%.

Files Patch % Lines
deepmd/pt/infer/inference.py 66.66% 5 Missing ⚠️
deepmd/pt/train/training.py 50.00% 5 Missing ⚠️
deepmd/pt/utils/finetune.py 20.00% 4 Missing ⚠️
deepmd/pt/entrypoints/main.py 66.66% 3 Missing ⚠️
deepmd/pt/model/task/fitting.py 25.00% 3 Missing ⚠️
deepmd/pt/utils/dataloader.py 40.00% 3 Missing ⚠️
deepmd/pt/model/model/model.py 60.00% 2 Missing ⚠️
deepmd/pt/train/wrapper.py 50.00% 2 Missing ⚠️
deepmd/env.py 66.66% 1 Missing ⚠️
deepmd/pt/model/task/dipole.py 50.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3222   +/-   ##
=======================================
  Coverage   74.78%   74.78%           
=======================================
  Files         362      362           
  Lines       32396    32408   +12     
  Branches     1594     1594           
=======================================
+ Hits        24226    24237   +11     
- Misses       7245     7246    +1     
  Partials      925      925           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm merged commit 22197f5 into deepmodeling:devel Feb 5, 2024
45 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants