Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more abstractmethods to universal DeepPot #3175

Merged
merged 2 commits into from
Jan 24, 2024
Merged

add more abstractmethods to universal DeepPot #3175

merged 2 commits into from
Jan 24, 2024

Commits on Jan 24, 2024

  1. add abstractmethod get_ntypes and get_type_map to universal DeepPot 

    They are used by the downstream APIs, so must be implemented.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
    @njzjz
    njzjz committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    bbd6170 View commit details
    Browse the repository at this point in the history

  2. also add get_dim_fparam and get_dim_aparam 

    Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
    @njzjz
    njzjz committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    af6b05e View commit details
    Browse the repository at this point in the history