-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cc: refactor DeepPot to support multiple backends #3142
cc: refactor DeepPot to support multiple backends #3142
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #3142 +/- ##
==========================================
+ Coverage 76.18% 76.24% +0.05%
==========================================
Files 252 269 +17
Lines 25374 25516 +142
Branches 1579 1583 +4
==========================================
+ Hits 19332 19455 +123
- Misses 5117 5134 +17
- Partials 925 927 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
See https://stackoverflow.com/a/13444839/9567349 Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
nlist_data.make_inlist(nlist); | ||
} | ||
if (dtype == tensorflow::DT_DOUBLE) { | ||
int ret = session_input_tensors<double>( |
Check notice
Code scanning / CodeQL
Unused local variable
run_model<double>(dener, dforce_, dvirial, session, input_tensors, atommap, | ||
nframes, nghost); | ||
} else { | ||
int ret = session_input_tensors<float>( |
Check notice
Code scanning / CodeQL
Unused local variable
std::vector<std::pair<std::string, Tensor>> input_tensors; | ||
|
||
if (dtype == tensorflow::DT_DOUBLE) { | ||
int nloc = session_input_tensors_mixed_type<double>( |
Check notice
Code scanning / CodeQL
Unused local variable
run_model<double>(dener, dforce_, dvirial, datom_energy_, datom_virial_, | ||
session, input_tensors, atommap, nframes); | ||
} else { | ||
int nloc = session_input_tensors_mixed_type<float>( |
Check notice
Code scanning / CodeQL
Unused local variable
run_model<double>(dener, dforce_, dvirial, datom_energy_, datom_virial_, | ||
session, input_tensors, atommap, nframes); | ||
} else { | ||
int nloc = session_input_tensors_mixed_type<float>( |
Check notice
Code scanning / CodeQL
Declaration hides variable
std::vector<std::pair<std::string, Tensor>> input_tensors; | ||
|
||
if (dtype == tensorflow::DT_DOUBLE) { | ||
int ret = session_input_tensors<double>(input_tensors, dcoord_, ntypes, |
Check notice
Code scanning / CodeQL
Unused local variable
run_model<double>(dener, dforce_, dvirial, datom_energy_, datom_virial_, | ||
session, input_tensors, atommap, nframes); | ||
} else { | ||
int ret = session_input_tensors<float>(input_tensors, dcoord_, ntypes, |
Check notice
Code scanning / CodeQL
Unused local variable
@CodiumAI-Agent /review --pr_reviewer.inline_code_comments=true |
PR Analysis(review updated until commit 5903415)
PR Feedback💡 General suggestions: The PR seems to be a significant refactoring effort. It would be beneficial to include more detailed comments explaining the changes and their implications. Also, it would be helpful to add tests to ensure that the refactoring does not break existing functionality. ✨ Usage guide:Overview:
With a configuration file, use the following template:
See the review usage page for a comprehensive guide on using this tool. |
Persistent review updated to latest commit 5903415 |
See #3119.
At this time, only TF is supported in such the multiple-backend framework.