Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add native Networks for mutiple Network classes #3117

Merged
merged 9 commits into from
Jan 10, 2024
Merged

add native Networks for mutiple Network classes #3117

merged 9 commits into from
Jan 10, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jan 9, 2024

No description provided.

@njzjz
add Networks
ff76186 
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz
Merge remote-tracking branch 'origin/devel' into networks
6dc8d00
@github-actions github-actions bot added the Python label Jan 9, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2024 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (398f037) 76.00% compared to head (278c29e) 75.96%.

Files Patch % Lines
deepmd_utils/model_format/network.py 90.90% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #3117      +/-   ##
==========================================
- Coverage   76.00%   75.96%   -0.04%     
==========================================
  Files         251      226      -25     
  Lines       25300    20883    -4417     
  Branches     1598      907     -691     
==========================================
- Hits        19228    15863    -3365     
+ Misses       5133     4483     -650     
+ Partials      939      537     -402

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz
fix assert for old numpy version
996d6e4 
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz mentioned this pull request Jan 9, 2024
Closed
37 tasks
@njzjz njzjz changed the title add Networks add native Networks for mutiple Network classes Jan 9, 2024
@njzjz njzjz mentioned this pull request Jan 9, 2024
Merged
@njzjz
Merge branch 'devel' into networks
23eae19
@njzjz
renames Networks to NetworkCollection
a209d1a 
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz
add check_completeness
811447d 
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz
make NetworkCollection more general
74cbf38 
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz marked this pull request as draft January 10, 2024 04:17
@njzjz
Merge remote-tracking branch 'origin/devel' into networks
a5be8bb
@njzjz
refactor
278c29e 
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz marked this pull request as ready for review January 10, 2024 05:38
@wanghan-iapcm wanghan-iapcm merged commit 43f9639 into deepmodeling:devel Jan 10, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghan-iapcm wanghan-iapcm wanghan-iapcm approved these changes

Assignees
No one assigned
Labels
Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njzjz @wanghan-iapcm