fix GPU mapping error for Horovod + finetune #3048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing finetune with Horovod, the same error as deepmodeling#2712 throws at what I modified in this PR. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3048 +/- ##
=======================================
Coverage 75.73% 75.73%
=======================================
Files 245 245
Lines 24685 24686 +1
Branches 1591 1591
=======================================
+ Hits 18696 18697 +1
Misses 5054 5054
Partials 935 935 ☔ View full report in Codecov by Sentry. |
wanghan-iapcm
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fine-tuning with Horovod, the same error as #2712 is thrown at the place I modified in this PR.
It seems
tf.test.is_gpu_availablewill try to use all GPUs, buttf.config.get_visible_deviceswon't.