Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing initializations for extra embedding variables #3005

Merged
merged 8 commits into from
Nov 24, 2023

Conversation

nahso
Copy link
Collaborator

@nahso nahso commented Nov 22, 2023

No description provided.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4d1c5fd) 75.72% compared to head (780f862) 75.73%.

Files Patch % Lines
deepmd/utils/graph.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3005   +/-   ##
=======================================
  Coverage   75.72%   75.73%           
=======================================
  Files         245      245           
  Lines       24676    24686   +10     
  Branches     1591     1591           
=======================================
+ Hits        18687    18697   +10     
  Misses       5054     5054           
  Partials      935      935           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz self-requested a review November 22, 2023 19:23
Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghan-iapcm wanghan-iapcm merged commit f321046 into deepmodeling:devel Nov 24, 2023
39 checks passed
@njzjz njzjz added the bug label Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants