Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support DP native model format #2987

Closed
wants to merge 12 commits into from
Closed

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Nov 11, 2023

Support framework-independent DP native model format as described in #2982. One can use dp convert-from -i frozen_model.pb -o frozen_model.dp and dp convert-from dp -i frozen_model.dp -o frozen_model.pb to convert between each other.

This PR supports:

  • dp convert-from cli
  • EnergyModel
  • DescrptSeA
  • EnerFitting

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz linked an issue Nov 11, 2023 that may be closed by this pull request
37 tasks
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Attention: 159 lines in your changes are missing coverage. Please review.

Comparison is base (f181a30) 75.90% compared to head (e12c10f) 75.51%.

Files Patch % Lines
deepmd/fit/fitting.py 32.60% 31 Missing ⚠️
deepmd/descriptor/se.py 19.35% 25 Missing ⚠️
deepmd/model/model.py 47.61% 22 Missing ⚠️
deepmd/utils/convert_dp.py 33.33% 20 Missing ⚠️
deepmd/fit/ener.py 20.83% 19 Missing ⚠️
deepmd/descriptor/se_a.py 25.00% 12 Missing ⚠️
deepmd/model/ener.py 29.41% 12 Missing ⚠️
deepmd/utils/type_embed.py 35.71% 9 Missing ⚠️
deepmd/entrypoints/convert.py 28.57% 5 Missing ⚠️
deepmd/descriptor/descriptor.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2987      +/-   ##
==========================================
- Coverage   75.90%   75.51%   -0.40%     
==========================================
  Files         248      249       +1     
  Lines       25141    25357     +216     
  Branches     1598     1598              
==========================================
+ Hits        19084    19148      +64     
- Misses       5118     5270     +152     
  Partials      939      939              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
x
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Dec 15, 2023
Split from deepmodeling#2987.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
wanghan-iapcm pushed a commit that referenced this pull request Dec 15, 2023
Split from #2987.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
wanghan-iapcm pushed a commit that referenced this pull request Feb 14, 2024
…e TF, PT, and DP models (#3263)

Some codes are split from #2987.

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@njzjz njzjz closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Feature Request] Framework-independent DP model format
1 participant