Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to ruff formatter #2951

Merged
merged 6 commits into from
Nov 1, 2023
Merged

move to ruff formatter #2951

merged 6 commits into from
Nov 1, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Oct 26, 2023

njzjz and others added 2 commits October 26, 2023 16:27
@njzjz
Copy link
Member Author

njzjz commented Oct 26, 2023

It looks like the current ruff version still has some issues...

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (389d403) 75.23% compared to head (d1e1bb2) 75.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #2951   +/-   ##
=======================================
  Coverage   75.23%   75.23%           
=======================================
  Files         245      245           
  Lines       24678    24678           
  Branches     1599     1599           
=======================================
  Hits        18566    18566           
  Misses       5176     5176           
  Partials      936      936           
Files Coverage Δ
deepmd/entrypoints/train.py 84.25% <100.00%> (ø)
deepmd/utils/argcheck.py 96.07% <100.00%> (ø)
deepmd/utils/finetune.py 85.36% <100.00%> (ø)
deepmd/utils/tabulate.py 86.04% <ø> (ø)
deepmd/fit/polar.py 66.83% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@github-actions github-actions bot added the Docs label Oct 31, 2023
@njzjz njzjz marked this pull request as ready for review October 31, 2023 21:57
@njzjz
Copy link
Member Author

njzjz commented Oct 31, 2023

It looks like the current ruff version still has some issues...

I am going to mark this PR ready for review. Although there is still some deviations from black, it should be harmless.

@njzjz njzjz changed the title move to ruff-format move to ruff formatter Oct 31, 2023
@wanghan-iapcm wanghan-iapcm merged commit 1529e72 into deepmodeling:devel Nov 1, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants