Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Seeds of descriptor/fitting in dpmodel are not passed to network #3799

Closed
iProzd opened this issue May 21, 2024 · 0 comments · Fixed by #3880
Closed

[BUG] Seeds of descriptor/fitting in dpmodel are not passed to network #3799

iProzd opened this issue May 21, 2024 · 0 comments · Fixed by #3880
Assignees
@njzjz
Labels
bug

Comments

@iProzd
Copy link
Collaborator

iProzd commented May 21, 2024

Bug summary

Seeds of descriptor/fitting in dpmodel are not passed to network

DeePMD-kit Version

3.0.0a

Backend and its version

PyTorch v2.1.2

How did you download the software?

Built from source

Input Files, Running Commands, Error Log, etc.

See above

Steps to Reproduce

See above

Further Information, Files, and Links

No response
@iProzd iProzd added the bug label May 21, 2024
@iProzd iProzd mentioned this issue May 21, 2024
Merged
@njzjz njzjz self-assigned this Jun 14, 2024
@njzjz njzjz mentioned this issue Jun 14, 2024
Merged
@njzjz njzjz linked a pull request Jun 14, 2024 that will close this issue
feat: add seeds to dpmodel and fix seeds in tf & pt #3880
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 19, 2024
@njzjz
feat: add seeds to dpmodel and fix seeds in tf & pt (#3880)
0c472d1 
Fix #3799.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced flexibility in specifying seed values, allowing either an
integer or a list of integers.
- Enhanced seed parameter usage across various initialization methods
and classes for more controlled randomization.

- **Improvements**
- Updated seed initialization logic to include additional computations
and dynamic adjustments.
- Enhanced documentation for parameters in multiple classes, providing
clearer usage guidelines.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz closed this as completed Jun 19, 2024
njzjz added a commit to njzjz/deepmd-kit that referenced this issue Jul 3, 2024
@njzjz
[r2] fix seeds in se_a and se_atten (deepmodeling#3880)
e4ae74b 
Fix deepmodeling#3799.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

- **New Features**
- Introduced flexibility in specifying seed values, allowing either an
integer or a list of integers.
- Enhanced seed parameter usage across various initialization methods
and classes for more controlled randomization.

- **Improvements**
- Updated seed initialization logic to include additional computations
and dynamic adjustments.
- Enhanced documentation for parameters in multiple classes, providing
clearer usage guidelines.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
(cherry picked from commit 0c472d1)
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz mentioned this issue Jul 3, 2024
Merged
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this issue Sep 18, 2024
@njzjz @mtaillefumier
feat: add seeds to dpmodel and fix seeds in tf & pt (deepmodeling#3880)
590fa03 
Fix deepmodeling#3799.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced flexibility in specifying seed values, allowing either an
integer or a list of integers.
- Enhanced seed parameter usage across various initialization methods
and classes for more controlled randomization.

- **Improvements**
- Updated seed initialization logic to include additional computations
and dynamic adjustments.
- Enhanced documentation for parameters in multiple classes, providing
clearer usage guidelines.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njzjz njzjz

Labels
bug
Projects
No open projects
DeePMD-3.0.0 beta release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add seeds to dpmodel and fix seeds in tf & pt njzjz/deepmd-kit
2 participants
@njzjz @iProzd