Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor data_requirement to make it not a global variable #3522

Closed
github-actions bot opened this issue Mar 19, 2024 · 1 comment · Fixed by #3798
Closed

refactor data_requirement to make it not a global variable #3522

github-actions bot opened this issue Mar 19, 2024 · 1 comment · Fixed by #3798

Comments

@github-actions
Copy link

this is not a good way to do things. This is some global variable to which
anyone can write and there is no good way to keep track of the changes

Line: 74

)
# TODO: refactor data_requirement to make it not a global variable
# this is not a good way to do things. This is some global variable to which
# anyone can write and there is no good way to keep track of the changes
data_requirement = {}
def add_data_requirement(
key: str,

@njzjz njzjz linked a pull request May 20, 2024 that will close this issue
github-merge-queue bot pushed a commit that referenced this issue May 23, 2024
Fix #3522. Fix #3540.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new property `input_requirement` across various models to
streamline data requirements handling.
- Added a new property `label_requirement` for loss classes to specify
data label requirements.

- **Bug Fixes**
- Refactored and removed outdated data requirement handling methods to
improve data processing efficiency.

- **Tests**
- Added new test cases to validate the `input_requirement` and
`label_requirement` properties.
- Updated existing tests to align with the new data requirements
handling approach.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Copy link
Author

Closed in commit 02e4ce9

mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this issue Sep 18, 2024
Fix deepmodeling#3522. Fix deepmodeling#3540.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new property `input_requirement` across various models to
streamline data requirements handling.
- Added a new property `label_requirement` for loss classes to specify
data label requirements.

- **Bug Fixes**
- Refactored and removed outdated data requirement handling methods to
improve data processing efficiency.

- **Tests**
- Added new test cases to validate the `input_requirement` and
`label_requirement` properties.
- Updated existing tests to align with the new data requirements
handling approach.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

0 participants