Feature: support the default
as the value of dft_functional
when initialize vdw
#5949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
ABACUS supports the automatic inference of
dft_functional
from pseudopotential, but its value will not be changed even after the inference is sucessful, this does not matter for other modules, but brings trouble to vdw d3 module because its parameter is functional-specific. The vdw d3 module should search for correct set of parameters according to the name of xc.However, there are users may think it is harmful to the user-friendliness.
What's changed
This change needs some discussion.

In this PR, ABACUS will pop a warning message like
rather than warning_quit with error message, but I am not sure this is really a good idea (at least now users will not get a crash when leaving
dft_functional
unset explicitly). I need suggestion from other developers.@mohanchen @QuantumMisaka @dyzheng @1041176461
Linked Issue
Fix #5944