Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Dm mixing #2442

Merged
merged 13 commits into from
May 17, 2023
Merged

Feature: Dm mixing #2442

merged 13 commits into from
May 17, 2023

Conversation

PeizeLin
Copy link
Collaborator

@PeizeLin PeizeLin commented May 11, 2023

The aim of this PR is to achieve issue #2457.

  1. add class Mix_Data
  2. add class Mix_DMk_2D
  3. add DM mixing for Exx_LRI
  4. unittests

PeizeLin and others added 2 commits May 12, 2023 10:11
2. add class Mix_DMk_2D
3. add DM mixing for Exx_LRI
@dyzheng
Copy link
Collaborator

dyzheng commented May 12, 2023

Title of this PR should be modified to "Feature: ...", please add detaild description.

@maki49
Copy link
Collaborator

maki49 commented May 12, 2023

@PeizeLin has difficulties in adding unit tests. (#2306). I will try to help for this.

* unuse GlobalV in Mix_DMk_2D

* add UT for dm_mixing using gmock

* add test for Mix_DMk_2D

* remove some useless code
Copy link
Collaborator

@dyzheng dyzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please write detail title and decription for this PR @PeizeLin

@PeizeLin PeizeLin changed the title Dm mixing Feature: Dm mixing May 16, 2023
@dyzheng dyzheng merged commit e54a39e into deepmodeling:develop May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants