Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: refresh the value of dft_functional when it is default soon after reading the pseudopotential #5944

Open
8 tasks
kirk0830 opened this issue Mar 2, 2025 · 0 comments · May be fixed by #5949
Open
8 tasks
Labels
Questions Raise your quesiton! We will answer it.

Comments

@kirk0830
Copy link
Collaborator

kirk0830 commented Mar 2, 2025

Describe the Code Quality Issue

(From issue #5938 ) I know ABACUS is designed to automatically infer the functional name from pseudopotential, but within one DFT machine, especially during the runtime, the functional name default is not reasonable.

Additional Context

No response

Task list for Issue attackers (only for developers)

  • Identify the specific code file or section with the code quality issue.
  • Investigate the issue and determine the root cause.
  • Research best practices and potential solutions for the identified issue.
  • Refactor the code to improve code quality, following the suggested solution.
  • Ensure the refactored code adheres to the project's coding standards.
  • Test the refactored code to ensure it functions as expected.
  • Update any relevant documentation, if necessary.
  • Submit a pull request with the refactored code and a description of the changes made.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Questions Raise your quesiton! We will answer it.
Projects
None yet
2 participants