Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the deprecations/warnings #45

Merged
merged 10 commits into from
Jul 19, 2024
Merged

Conversation

wx4stg
Copy link
Contributor

@wx4stg wx4stg commented Jul 17, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.12%. Comparing base (d7cbf87) to head (5774a2b).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   78.13%   78.12%   -0.02%     
==========================================
  Files          13       13              
  Lines        1866     1865       -1     
==========================================
- Hits         1458     1457       -1     
  Misses        408      408              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wx4stg
Copy link
Contributor Author

wx4stg commented Jul 17, 2024

Choosing not to resolve the datetime utcnow deprecation here:

ds.attrs['production_date'] = datetime.datetime.utcnow().strftime(

as doing so will break support for python 3.9. This will be interesting when we get to py 3.13 in the fall...

@wx4stg
Copy link
Contributor Author

wx4stg commented Jul 17, 2024

Choosing not to resolve FutureWarning: The behavior of DatetimeProperties.to_pydatetime is deprecated, in a future version this will return a Series containing python datetime objects instead of an ndarray. here:

self.datetime = pd.Series(self.data.event_time.data.flatten()).dt.to_pydatetime()

Because it doesn't matter whether this is a pandas series or numpy array (or even just a python list type), any collection will work. Explicitly converting to an array to silence this warning adds unnecessary overhead.

@wx4stg wx4stg marked this pull request as ready for review July 17, 2024 23:57
@deeplycloudy
Copy link
Owner

Thanks for the cleanup on all these. After review, lgtm; merging.

@deeplycloudy deeplycloudy merged commit f392af2 into deeplycloudy:master Jul 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants