-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve the deprecations/warnings #45
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
==========================================
- Coverage 78.13% 78.12% -0.02%
==========================================
Files 13 13
Lines 1866 1865 -1
==========================================
- Hits 1458 1457 -1
Misses 408 408 ☔ View full report in Codecov by Sentry. |
Choosing not to resolve the datetime utcnow deprecation here:
as doing so will break support for python 3.9. This will be interesting when we get to py 3.13 in the fall... |
Choosing not to resolve xlma-python/pyxlma/plot/xlma.py Line 149 in d7cbf87
Because it doesn't matter whether this is a pandas series or numpy array (or even just a python list type), any collection will work. Explicitly converting to an array to silence this warning adds unnecessary overhead. |
Thanks for the cleanup on all these. After review, lgtm; merging. |
No description provided.