Add FFT2 and FFT2 inverse #2845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2845 +/- ##
============================================
+ Coverage 72.08% 72.28% +0.19%
- Complexity 5126 7160 +2034
============================================
Files 473 708 +235
Lines 21970 31908 +9938
Branches 2351 3313 +962
============================================
+ Hits 15838 23066 +7228
- Misses 4925 7263 +2338
- Partials 1207 1579 +372
☔ View full report in Codecov by Sentry. |
zachgk
reviewed
Nov 11, 2023
| * @return The truncated or zero-padded input, transformed along the dimensions indicated by | ||
| * dims | ||
| */ | ||
| NDArray fft2(long[] sizes, long[] dims); |
There was a problem hiding this comment.
Can you use axes instead of dims to be more consistent with the other operations in NDArray? Otherwise, your contribution looks good
frankfliu
pushed a commit
that referenced
this pull request
Apr 26, 2024
* Added 2D FFT * Format java * Add default fft2 * Convert array to vectors * Add inverse fft2 * Add better assersion in ifft2 test * Add really better assersion in ifft2 test * Move cast bellow ifft2 for unsupported exception * Format java * changed dims to axes * changed dims to axes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about