Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tokenizer] Fixes tokenizer bug #2843

Merged
merged 1 commit into from
Nov 8, 2023
Merged

[tokenizer] Fixes tokenizer bug #2843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/tokenizers/src/main/java/ai/djl/huggingface/tokenizers/HuggingFaceTokenizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,7 +787,7 @@ public HuggingFaceTokenizer build() throws IOException {
return managed(HuggingFaceTokenizer.newInstance(vocab, merges, options));
}
throw new IOException("tokenizer.json file not found.");
} else if (Files.exists(tokenizerPath)) {
} else if (!Files.exists(tokenizerPath)) {
throw new IOException("Tokenizer file not exits: " + tokenizerPath);
}
return managed(HuggingFaceTokenizer.newInstance(tokenizerPath, options));
Expand Down
6 changes: 6 additions & 0 deletions ...ions/tokenizers/src/test/java/ai/djl/huggingface/tokenizers/HuggingFaceTokenizerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,12 @@ public void testTokenizer() throws IOException {
Assert.assertEquals(encodings.length, 2);
Assert.assertEquals(encodings[0].getIds(), ids);
}

Assert.assertThrows(
() -> {
Path file = Paths.get("build/tokenizer/non-exists.json");
HuggingFaceTokenizer.builder().optTokenizerPath(file).build();
});
}

@Test
Expand Down
Loading