Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Allows non-ServingTranslatorFactory for DJLServing #2148

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@codecov-commenter
Copy link

Codecov Report

Base: 72.08% // Head: 71.53% // Decreases project coverage by -0.55% ⚠️

Coverage data is based on head (27d1dfc) compared to base (bb5073f).
Patch coverage: 72.08% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2148      +/-   ##
============================================
- Coverage     72.08%   71.53%   -0.56%     
- Complexity     5126     6324    +1198     
============================================
  Files           473      625     +152     
  Lines         21970    27913    +5943     
  Branches       2351     3010     +659     
============================================
+ Hits          15838    19967    +4129     
- Misses         4925     6479    +1554     
- Partials       1207     1467     +260     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
...rc/main/java/ai/djl/modality/cv/output/Joints.java 71.42% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...main/java/ai/djl/modality/cv/output/Rectangle.java 72.41% <0.00%> (ø)
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
.../modality/cv/translator/ImageFeatureExtractor.java 0.00% <0.00%> (ø)
.../ai/djl/modality/cv/translator/YoloTranslator.java 27.77% <0.00%> (+18.95%) ⬆️
...modality/cv/translator/wrapper/FileTranslator.java 44.44% <ø> (ø)
...y/cv/translator/wrapper/InputStreamTranslator.java 44.44% <ø> (ø)
... and 559 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xyang16 xyang16 self-requested a review November 10, 2022 00:39
@frankfliu frankfliu merged commit d906b63 into deepjavalibrary:master Nov 10, 2022
@frankfliu frankfliu deleted the factory branch November 10, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants