Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Multiplication block #2110

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

patins1
Copy link
Contributor

@patins1 patins1 commented Oct 30, 2022

Adds a new block type that enables to use a custom aggregating function as opposed to summing of Linear block

@patins1
Copy link
Contributor Author

patins1 commented Nov 1, 2022

Hi, the build complains about:

Task :integration:pmdMain FAILED
..

2 PMD rule violations were found. See the report at: file:///home/runner/work/djl/djl/integration/build/reports/pmd/main.html

Is there any chance to open this file from this github site? I would not be able to reproduce it locally as I am using Windows and the Windows build seems OK, just not the ubuntu one

@frankfliu
Copy link
Contributor

@patins1
I fixed PMD issue, see my commit: 870fd60

A few comments:

  1. You should able to download the build artifacts which include the PMD report
  2. Please rebase from master branch instead of merge from master. Using rebase, the history is much easier to read in the PR

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2022

Codecov Report

Base: 72.08% // Head: 71.42% // Decreases project coverage by -0.66% ⚠️

Coverage data is based on head (870fd60) compared to base (bb5073f).
Patch coverage: 71.88% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2110      +/-   ##
============================================
- Coverage     72.08%   71.42%   -0.67%     
- Complexity     5126     6289    +1163     
============================================
  Files           473      625     +152     
  Lines         21970    27849    +5879     
  Branches       2351     2999     +648     
============================================
+ Hits          15838    19890    +4052     
- Misses         4925     6496    +1571     
- Partials       1207     1463     +256     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
...rc/main/java/ai/djl/modality/cv/output/Joints.java 71.42% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...main/java/ai/djl/modality/cv/output/Rectangle.java 72.41% <0.00%> (ø)
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
.../modality/cv/translator/ImageFeatureExtractor.java 0.00% <0.00%> (ø)
.../ai/djl/modality/cv/translator/YoloTranslator.java 27.77% <0.00%> (+18.95%) ⬆️
...modality/cv/translator/wrapper/FileTranslator.java 44.44% <ø> (ø)
...y/cv/translator/wrapper/InputStreamTranslator.java 44.44% <ø> (ø)
... and 559 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@patins1
Copy link
Contributor Author

patins1 commented Nov 2, 2022

frankfliu thanks for fixing , i tried "Download log archives" but that's just log files, where can i download the test results (in html form) ?

@frankfliu
Copy link
Contributor

@patins1
I re-triggered your PR, and now it passed the build.

You can find the report.zip file at the bottom of summary page: https://github.com/deepjavalibrary/djl/actions/runs/3371014936

@patins1
Copy link
Contributor Author

patins1 commented Nov 3, 2022

Scrolling down is clearly a useful skill :-$

@zachgk zachgk merged commit c5d2885 into deepjavalibrary:master Nov 8, 2022
KexinFeng pushed a commit to KexinFeng/djl that referenced this pull request Nov 9, 2022
* Added Multiplication block

* improved comments

* Address PMD issues

Co-authored-by: Frank Liu <frankfliu2000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants