[api] Allow to show NDArray content in Debugger 2 #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 72.08% // Head: 70.24% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2080 +/- ##
============================================
- Coverage 72.08% 70.24% -1.85%
- Complexity 5126 6074 +948
============================================
Files 473 603 +130
Lines 21970 26893 +4923
Branches 2351 2912 +561
============================================
+ Hits 15838 18892 +3054
- Misses 4925 6588 +1663
- Partials 1207 1413 +206
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
KexinFeng
force-pushed
the
nd
branch
2 times, most recently
from
83d2cb7
to
c5c5f97
Compare
add message add message
frankfliu
reviewed
Oct 12, 2022
frankfliu
approved these changes
Oct 14, 2022
KexinFeng
added a commit
to KexinFeng/djl
that referenced
this pull request
Oct 26, 2022
* [api] Allow show NDArray content in debugger * add message add message add message * add message * add message * add message * link * link Co-authored-by: Frank Liu <frankfliu2000@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous solution still suffers from a slowing down when printing the string outside the debugger mode. Here the solution is to utillize the existing pruning mechanism, and put the execution of
init(array)also under the condition that the array is not too large.A testing code is added.