Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds TabNet model for tabular dataset in modelzoo #2036

Merged
merged 10 commits into from
Sep 29, 2022
Merged

Adds TabNet model for tabular dataset in modelzoo #2036

merged 10 commits into from
Sep 29, 2022

Conversation

warthecatalyst
Copy link
Contributor

TabNet model almost complete, except for its test and some minor bugs
What I've done in this pr:

  1. add a SparseMax function in nn.core(already been merged)
  2. add an activation function: tabNetGLU in nn.Activation and its corresponding test function testTabNetGLU in ActivationTest
  3. add feature transformer, attention transformer and Decision Step in tabNet
  4. tabNet is a Block which extends AbstractBlock and it's functions like forwardInternal, getOutputShapes and so on
  5. tabNet has a builder class for users to use

TODO: test for tabNet

zachgk
zachgk reviewed Sep 26, 2022
View reviewed changes
Copy link
Contributor

@zachgk zachgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One smaller comment, but otherwise it looks pretty good. Just add a working test, maybe a Translator, and we should merge it

api/src/main/java/ai/djl/nn/Activation.java Outdated Show resolved Hide resolved
api/src/main/java/ai/djl/nn/core/SparseMax.java Show resolved Hide resolved
@warthecatalyst
what I've done in this commit:
e67c4a4 
1.move the Activation Function tabNetGLU into TabNet and it's corresponding test into tabNetTest
2.finish the debugging of TabNet and TabNetLoss, it can be successfully trained now
3.finish the testTrainAndLogic() in TabNetTest
@zachgk zachgk merged commit c2c0793 into deepjavalibrary:master Sep 29, 2022
@warthecatalyst warthecatalyst deleted the tabNet branch September 29, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachgk zachgk zachgk approved these changes

@frankfliu frankfliu Awaiting requested review from frankfliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@warthecatalyst @zachgk