fix some bugs in pytorch based examples #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddvenk
force-pushed
the
pytorch-example-bugs
branch
from
afb3001
to
b04b861
Compare
frankfliu
reviewed
Sep 13, 2022
| @@ -40,13 +40,15 @@ public BigGANTranslator(float truncation) { | |||
| /** {@inheritDoc} */ | |||
| @Override | |||
| public Image[] processOutput(TranslatorContext ctx, NDList list) { | |||
| NDArray output = list.get(0).addi(1).muli(128).clip(0, 255); | |||
| Image[] images; | |||
| try (NDArray output = list.get(0).duplicate().addi(1).muli(128).clip(0, 255)) { | |||
There was a problem hiding this comment.
use try for NDArray makes the code looks ugly.
We generally don't use try-with-resource in Translator.
There was a problem hiding this comment.
got it - i'll update
| @@ -52,7 +52,10 @@ public static void main(String[] args) throws IOException, ModelException, Trans | |||
| Image input = ImageFactory.getInstance().fromFile(Paths.get(imagePath)); | |||
| Image output = transfer(input, artist); | |||
|
|
|||
| logger.info("Using PyTorch Engine. " + artist + " painting generated."); | |||
| logger.info( | |||
There was a problem hiding this comment.
logger.info("Using PyTorch Engine. {} painting generated. Image saved in build/output/cyclegan", artist);
2e491b2
to
98bebce
Compare
siddvenk
force-pushed
the
pytorch-example-bugs
branch
from
98bebce
to
9191194
Compare
frankfliu
approved these changes
Sep 13, 2022
Codecov Report
@@ Coverage Diff @@
## master #2009 +/- ##
============================================
- Coverage 72.08% 69.97% -2.12%
- Complexity 5126 5948 +822
============================================
Files 473 587 +114
Lines 21970 26283 +4313
Branches 2351 2860 +509
============================================
+ Hits 15838 18392 +2554
- Misses 4925 6509 +1584
- Partials 1207 1382 +175
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While changing to PyTorch as the default engine I noticed some bugs in examples that rely on PyTorch engine related to #1774.
This changes fixes those examples. I guess this also shows that we are skipping some tests in our current CI, since this issue would have been caught before had the tests run automatically.