[doc] Immutable array output from InferenceMode PyTorch #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1822 +/- ##
============================================
- Coverage 72.08% 69.65% -2.44%
- Complexity 5126 5503 +377
============================================
Files 473 524 +51
Lines 21970 24339 +2369
Branches 2351 2652 +301
============================================
+ Hits 15838 16954 +1116
- Misses 4925 6076 +1151
- Partials 1207 1309 +102
Continue to review full report at Codecov.
|
lanking520
approved these changes
Jul 22, 2022
KexinFeng
added a commit
to KexinFeng/djl
that referenced
this pull request
Jul 22, 2022
…ary#1822) * immutable array from InferenceMode PyTorch * javadoc * javadoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doc change originates from issue 1774. It reminds user that the output array during inference mode is immutable. When they need to change the output NDArray in a implementation of postProcessor, they can try
array.duplicate()as suggested in issue 1774.