[BugFix] Fix breaking behaviour in 0.18.0 #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfliu
reviewed
Jul 15, 2022
siddvenk
reviewed
Jul 15, 2022
| @@ -373,7 +373,7 @@ private int addIndexItem(String indexItem, int argIndex, Object[] args) { | |||
| if (array.getDataType() == DataType.BOOLEAN) { | |||
| indices.add(new NDIndexBooleans(array)); | |||
| return argIndex + 1; | |||
| } else if (array.getDataType().isInteger()) { | |||
| } else { | |||
There was a problem hiding this comment.
Would this cause issues if DataType is UNKNOWN or STRING? https://github.com/deepjavalibrary/djl/blob/master/api/src/main/java/ai/djl/ndarray/types/DataType.java#L28-L34 seems like what we need to cover in this code, and not UNKNOWN or STRING
There was a problem hiding this comment.
Thanks for spotting this. I'll update it.
Codecov Report
@@ Coverage Diff @@
## master #1801 +/- ##
============================================
- Coverage 72.08% 69.60% -2.49%
- Complexity 5126 5493 +367
============================================
Files 473 524 +51
Lines 21970 24318 +2348
Branches 2351 2645 +294
============================================
+ Hits 15838 16927 +1089
- Misses 4925 6081 +1156
- Partials 1207 1310 +103
Continue to review full report at Codecov.
|
frankfliu
approved these changes
Jul 15, 2022
siddvenk
approved these changes
Jul 15, 2022
KexinFeng
added a commit
to KexinFeng/djl
that referenced
this pull request
Jul 22, 2022
NDIndex tests of float index are also added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes issue.
The fix is to allow other datatype of index than just integer. The dataType conversion to
Longhas already implemented before in JniUtils