[ONNXRuntime] fix naming #1608
Merged
[ONNXRuntime] fix naming #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfliu
reviewed
Apr 28, 2022
| OrtNDArray ortNDArray = sub.from(inputs.get(i)); | ||
| container.put(inputNames.get(i), ortNDArray.getTensor()); | ||
| // If input data has name | ||
| if (inputs.get(0).getName() != null) { |
There was a problem hiding this comment.
We should not assume all input has name
There was a problem hiding this comment.
User should either provide all names to the NDArray or provides no name
Codecov Report
@@ Coverage Diff @@
## master #1608 +/- ##
============================================
- Coverage 72.08% 70.81% -1.28%
- Complexity 5126 5399 +273
============================================
Files 473 504 +31
Lines 21970 23631 +1661
Branches 2351 2573 +222
============================================
+ Hits 15838 16734 +896
- Misses 4925 5614 +689
- Partials 1207 1283 +76
Continue to review full report at Codecov.
|
Change-Id: I94a580dc81c0229d8ccf6870a416d8d7bdff30aa
frankfliu
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the bug on the name where user has placed name inside.