Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNXRuntime] fix naming #1608

Merged
merged 2 commits into from
Apr 28, 2022
Merged

[ONNXRuntime] fix naming #1608

merged 2 commits into from
Apr 28, 2022

Conversation

lanking520
Copy link
Contributor

Description

Fixed the bug on the name where user has placed name inside.

OrtNDArray ortNDArray = sub.from(inputs.get(i));
container.put(inputNames.get(i), ortNDArray.getTensor());
// If input data has name
if (inputs.get(0).getName() != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not assume all input has name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User should either provide all names to the NDArray or provides no name

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2022

Codecov Report

Merging #1608 (68e052b) into master (bb5073f) will decrease coverage by 1.27%.
The diff coverage is 59.61%.

@@             Coverage Diff              @@
##             master    #1608      +/-   ##
============================================
- Coverage     72.08%   70.81%   -1.28%     
- Complexity     5126     5399     +273     
============================================
  Files           473      504      +31     
  Lines         21970    23631    +1661     
  Branches       2351     2573     +222     
============================================
+ Hits          15838    16734     +896     
- Misses         4925     5614     +689     
- Partials       1207     1283      +76     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <ø> (-5.24%) ⬇️
...odality/cv/translator/BigGANTranslatorFactory.java 33.33% <0.00%> (+8.33%) ⬆️
...nslator/InstanceSegmentationTranslatorFactory.java 14.28% <0.00%> (-3.90%) ⬇️
.../modality/cv/translator/YoloTranslatorFactory.java 8.33% <0.00%> (-1.67%) ⬇️
...i/djl/modality/cv/translator/YoloV5Translator.java 5.69% <0.00%> (ø)
...odality/cv/translator/YoloV5TranslatorFactory.java 8.33% <0.00%> (-1.67%) ⬇️
...pi/src/main/java/ai/djl/ndarray/BytesSupplier.java 54.54% <0.00%> (-12.13%) ⬇️
...ain/java/ai/djl/ndarray/index/dim/NDIndexPick.java 100.00% <ø> (ø)
api/src/main/java/ai/djl/nn/Blocks.java 75.00% <0.00%> (-25.00%) ⬇️
... and 233 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3953410...68e052b. Read the comment docs.

Change-Id: I94a580dc81c0229d8ccf6870a416d8d7bdff30aa
@lanking520 lanking520 merged commit 8ff1b4f into deepjavalibrary:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants