Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xgb] Fixes missing anonymous classes #1572

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

frankfliu
Copy link
Contributor

Change-Id: I79645d18cd26aba2e8e4dff482b7efebbcecc096

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Change-Id: I79645d18cd26aba2e8e4dff482b7efebbcecc096
@frankfliu frankfliu requested a review from zachgk as a code owner April 14, 2022 18:31
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #1572 (c03248f) into master (bb5073f) will decrease coverage by 1.25%.
The diff coverage is 58.40%.

@@             Coverage Diff              @@
##             master    #1572      +/-   ##
============================================
- Coverage     72.08%   70.83%   -1.26%     
- Complexity     5126     5394     +268     
============================================
  Files           473      503      +30     
  Lines         21970    23582    +1612     
  Branches       2351     2561     +210     
============================================
+ Hits          15838    16705     +867     
- Misses         4925     5598     +673     
- Partials       1207     1279      +72     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <ø> (-5.24%) ⬇️
...odality/cv/translator/BigGANTranslatorFactory.java 33.33% <0.00%> (+8.33%) ⬆️
...nslator/InstanceSegmentationTranslatorFactory.java 14.28% <0.00%> (-3.90%) ⬇️
.../modality/cv/translator/YoloTranslatorFactory.java 8.33% <0.00%> (-1.67%) ⬇️
...i/djl/modality/cv/translator/YoloV5Translator.java 5.69% <0.00%> (ø)
...odality/cv/translator/YoloV5TranslatorFactory.java 8.33% <0.00%> (-1.67%) ⬇️
...pi/src/main/java/ai/djl/ndarray/BytesSupplier.java 54.54% <0.00%> (-12.13%) ⬇️
...ain/java/ai/djl/ndarray/index/dim/NDIndexPick.java 100.00% <ø> (ø)
api/src/main/java/ai/djl/nn/Blocks.java 75.00% <0.00%> (-25.00%) ⬇️
... and 229 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef7d6ca...c03248f. Read the comment docs.

@frankfliu frankfliu merged commit 0d06682 into deepjavalibrary:master Apr 15, 2022
@frankfliu frankfliu deleted the xgb branch April 15, 2022 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants