Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure on GPU #1279

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Fix build failure on GPU #1279

merged 1 commit into from
Oct 8, 2021

Conversation

frankfliu
Copy link
Contributor

Change-Id: I6a916d24668d3ed04cb7c43ca70455a5d049b0d6

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Change-Id: I6a916d24668d3ed04cb7c43ca70455a5d049b0d6
@@ -40,7 +40,6 @@ public void testPlatform() throws IOException {
Assert.assertEquals(system.getClassifier(), "linux-x86_64");
Assert.assertEquals(system.getOsPrefix(), "linux");
Assert.assertEquals(system.getOsArch(), "x86_64");
Assert.assertNull(system.getCudaArch());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we remove this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CudaArch is inherited from system detected value. On GPU machine, this won't be null.

@frankfliu frankfliu merged commit ff659d8 into deepjavalibrary:master Oct 8, 2021
@frankfliu frankfliu deleted the tf branch October 8, 2021 17:24
maaquib pushed a commit to maaquib/djl that referenced this pull request Mar 8, 2024
Co-authored-by: sindhuso <sindhuso@3c0630156b9b.ant.amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants