Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pytorch] Fix PtNDArray interoperability with other engine #1270

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

frankfliu
Copy link
Contributor

Change-Id: If0d602c897937b25a9d1b1808568a9bb4fbc582e

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Change-Id: If0d602c897937b25a9d1b1808568a9bb4fbc582e
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2021

Codecov Report

Merging #1270 (3805f87) into master (9aaaa66) will increase coverage by 0.01%.
The diff coverage is 78.94%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1270      +/-   ##
============================================
+ Coverage     71.99%   72.01%   +0.01%     
- Complexity     5114     5117       +3     
============================================
  Files           473      473              
  Lines         21913    21945      +32     
  Branches       2345     2347       +2     
============================================
+ Hits          15777    15804      +27     
- Misses         4932     4937       +5     
  Partials       1204     1204              
Impacted Files Coverage Δ
.../src/main/java/ai/djl/dlr/engine/DlrNDManager.java 78.37% <0.00%> (ø)
.../src/main/java/ai/djl/ml/xgboost/XgbNDManager.java 75.51% <0.00%> (ø)
...src/main/java/ai/djl/mxnet/engine/MxNDManager.java 87.12% <0.00%> (ø)
...n/java/ai/djl/onnxruntime/engine/OrtNDManager.java 72.22% <0.00%> (ø)
...n/java/ai/djl/paddlepaddle/engine/PpNDManager.java 87.50% <0.00%> (ø)
...ain/java/ai/djl/tensorflow/engine/TfNDManager.java 89.31% <0.00%> (ø)
...ain/java/ai/djl/tflite/engine/TfLiteNDManager.java 80.76% <0.00%> (ø)
...c/main/java/ai/djl/pytorch/engine/PtNDArrayEx.java 85.54% <89.79%> (-0.27%) ⬇️
...c/main/java/ai/djl/pytorch/engine/PtNDManager.java 93.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aaaa66...3805f87. Read the comment docs.

@frankfliu frankfliu merged commit 8a431ba into deepjavalibrary:master Oct 5, 2021
@frankfliu frankfliu deleted the ptnd branch October 5, 2021 17:44
maaquib pushed a commit to maaquib/djl that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants