Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[djl-serving] Add dynamic batch feature back #1154

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

frankfliu
Copy link
Contributor

Change-Id: I5a70eb894e749f02377a534509881ce25211c2e8

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2021

Codecov Report

Merging #1154 (f58f351) into master (0df8265) will decrease coverage by 0.05%.
The diff coverage is 58.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1154      +/-   ##
============================================
- Coverage     70.26%   70.20%   -0.06%     
+ Complexity     5339     5337       -2     
============================================
  Files           513      513              
  Lines         23664    23681      +17     
  Branches       2552     2556       +4     
============================================
- Hits          16627    16626       -1     
- Misses         5674     5687      +13     
- Partials       1363     1368       +5     
Impacted Files Coverage Δ
...src/main/java/ai/djl/serving/wlm/ModelManager.java 78.76% <0.00%> (-1.42%) ⬇️
...a/ai/djl/serving/wlm/TemporaryBatchAggregator.java 0.00% <0.00%> (ø)
.../main/java/ai/djl/serving/wlm/BatchAggregator.java 64.28% <37.50%> (-11.58%) ⬇️
...ava/ai/djl/translate/ServingTranslatorFactory.java 80.26% <80.00%> (-0.95%) ⬇️
api/src/main/java/ai/djl/modality/Output.java 96.29% <100.00%> (-0.26%) ⬇️
.../ai/djl/serving/http/ManagementRequestHandler.java 89.84% <100.00%> (-1.57%) ⬇️
...a/ai/djl/serving/wlm/PermanentBatchAggregator.java 100.00% <100.00%> (ø)
api/src/main/java/ai/djl/repository/Artifact.java 87.80% <0.00%> (-1.63%) ⬇️
.../main/java/ai/djl/benchmark/AbstractBenchmark.java 90.17% <0.00%> (-1.16%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0df8265...f58f351. Read the comment docs.

@frankfliu frankfliu force-pushed the batch branch 2 times, most recently from d8894f1 to 6f5d06b Compare August 9, 2021 01:05
Change-Id: I5a70eb894e749f02377a534509881ce25211c2e8
@frankfliu frankfliu merged commit f97e23e into deepjavalibrary:master Aug 16, 2021
@frankfliu frankfliu deleted the batch branch August 16, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants