Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NDArrayAdapter #1109

Merged
merged 1 commit into from
Jul 18, 2021
Merged

Refactor NDArrayAdapter #1109

merged 1 commit into from
Jul 18, 2021

Conversation

frankfliu
Copy link
Contributor

  1. Remove default implemenation from NDArrayAdapter for required API
  2. Throw Unsupported exception for OrtNDArray

Change-Id: Ifab71491610c145ad67dc43dffcf72e080023433

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2021

Codecov Report

Merging #1109 (0fa6e7a) into master (7b31d94) will increase coverage by 0.17%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1109      +/-   ##
============================================
+ Coverage     69.87%   70.05%   +0.17%     
- Complexity     5248     5277      +29     
============================================
  Files           514      514              
  Lines         23486    23480       -6     
  Branches       2515     2515              
============================================
+ Hits          16412    16448      +36     
+ Misses         5734     5695      -39     
+ Partials       1340     1337       -3     
Impacted Files Coverage Δ
...i/src/main/java/ai/djl/ndarray/NDArrayAdapter.java 6.66% <ø> (+6.66%) ⬆️
...ne/src/main/java/ai/djl/dlr/engine/DlrNDArray.java 31.57% <ø> (+0.80%) ⬆️
...st/src/main/java/ai/djl/ml/xgboost/XgbNDArray.java 55.35% <0.00%> (+2.52%) ⬆️
.../main/java/ai/djl/onnxruntime/engine/OrtUtils.java 19.44% <0.00%> (-1.15%) ⬇️
.../src/main/java/ai/djl/ml/xgboost/XgbNDManager.java 73.58% <62.50%> (+20.75%) ⬆️
api/src/main/java/ai/djl/BaseModel.java 73.61% <0.00%> (+0.69%) ⬆️
api/src/main/java/ai/djl/repository/Artifact.java 91.37% <0.00%> (+1.72%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b31d94...0fa6e7a. Read the comment docs.

1. Remove default implemenation from NDArrayAdapter for required API
2. Throw Unsupported exception for OrtNDArray
3. Fix XGBoost NDArray creation bug

Change-Id: I9f19d064245e47caf0a8718a0b706d6fe8934164
@frankfliu frankfliu merged commit eac9682 into deepjavalibrary:master Jul 18, 2021
@frankfliu frankfliu deleted the nd branch July 18, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants