Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deepin Kernel SIG] [Debian] binder: Export close_fd_get_file and can_nice #552

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

Avenger-285714
Copy link
Collaborator

Fix follow compile errors:
ERROR: modpost: "close_fd_get_file" [drivers/android/binder_linux.ko] undefined! ERROR: modpost: "can_nice" [drivers/android/binder_linux.ko] undefined!

Fix follow compile errors:
ERROR: modpost: "close_fd_get_file" [drivers/android/binder_linux.ko] undefined!
ERROR: modpost: "can_nice" [drivers/android/binder_linux.ko] undefined!

Signed-off-by: WangYuli <wangyuli@uniontech.com>
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from avenger-285714. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. fs/file.c文件中,新增的EXPORT_SYMBOL_GPL(close_fd_get_file);语句将close_fd_get_file函数导出为GPL许可证下的符号。这可能会影响到其他模块或驱动程序的使用,需要确认是否有必要这样做,以及是否所有使用该函数的模块或驱动程序都符合GPL许可证的要求。

  2. kernel/sched/core.c文件中,新增的EXPORT_SYMBOL_GPL(can_nice);语句将can_nice函数导出为GPL许可证下的符号。同样,需要确认是否有必要这样做,以及是否所有使用该函数的模块或驱动程序都符合GPL许可证的要求。

  3. 代码中没有明显的语法或逻辑错误。

  4. 代码中没有明显的性能问题。

  5. 代码中没有明显的安全问题。

总体来说,这两个改动主要是为了导出函数,需要确保这样做是符合项目许可证要求的,并且不会对其他模块或驱动程序的使用造成影响。

@Avenger-285714 Avenger-285714 merged commit a375c86 into deepin-community:linux-6.6.y Jan 9, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants