Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deepin-Kernel-SIG] [linux 6.6-y] config: deepin_loongarch_desktop_defconfig: Disable CONFIG_DRM_LEGACY #550

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

opsiff
Copy link
Member

@opsiff opsiff commented Jan 7, 2025

The config aims to support very old agp gpu drivers.
It show not used in loongarch, disable it for compat loongarch gpu driver,
as other arch configs do, disable it in loongarch now.
If we sure need it, we can bring it back.

The config aims to support very old agp gpu drivers.
It show not used in loongarch, disable it for compat loongarch gpu driver,
as other arch configs do, disable it in loongarch now.
If we sure need it, we can bring it back.

Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
@deepin-ci-robot
Copy link

deepin pr auto review

在代码审查过程中,我会关注以下几个方面:语法和逻辑错误、代码质量、性能优化以及安全性问题。以下是针对您提供的代码片段的审查意见:

代码质量

  • 移除不必要的配置项:移除了 CONFIG_DRM_LEGACY=y 这一行。如果这个配置项不再需要,那么移除是合理的。但是,如果这个配置项是必要的,那么移除可能会导致功能缺失或系统不稳定。

性能优化

  • 配置项的移除可能影响性能:如果 CONFIG_DRM_LEGACY 是为了优化性能而添加的,那么移除它可能会对性能产生负面影响。需要确认移除这个配置项是否会对系统性能产生不利影响。

安全性

  • 配置项的安全性:没有涉及到安全性相关的配置项,因此在这个代码片段中没有发现与安全性相关的问题。

语法和逻辑

  • 代码格式:代码格式看起来是正确的,没有发现明显的语法或逻辑错误。

其他建议

  • 配置项的文档:如果移除 CONFIG_DRM_LEGACY 是有意为之,建议在提交信息中说明原因,以便其他开发者理解这一变更的背景和影响。
  • 代码审查流程:建议在代码提交前进行代码审查,以确保代码质量和系统稳定性。

总体来说,这个代码变更看起来是合理的,但需要确保移除 CONFIG_DRM_LEGACY 不会对系统产生负面影响。如果这个配置项是必要的,那么应该撤销这个变更。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MingcongBai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Avenger-285714
Copy link
Collaborator

得看下其它架构是否也开了,有的话最好一并关掉

@Avenger-285714
Copy link
Collaborator

/lgtm

@opsiff
Copy link
Member Author

opsiff commented Jan 8, 2025

得看下其它架构是否也开了,有的话最好一并关掉

其他架构没有开

@opsiff opsiff merged commit d0a4257 into linux-6.6.y Jan 8, 2025
7 of 10 checks passed
@opsiff opsiff deleted the linux-6.6.y-2025-01-08-config branch January 8, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants