Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deepin-Kernel-SIG] [linux 6.6-y] deepin: config: Enable NO_HZ_FULL #549

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

opsiff
Copy link
Member

@opsiff opsiff commented Jan 7, 2025

There is reportedly no (longer) significant overhead to this when it is not enabled at runtime, see
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=804857#66

By default, without passing the nohz_full parameter, this behaves just like NO_HZ_IDLE(default), enable it by passing nohz_full=all or nohz_full=cpulist, see https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/kernel/time/Kconfig?h=v6.6#n142 https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/Documentation/admin-guide/kernel-parameters.rst?h=v6.6#n80

There is reportedly no (longer) significant overhead to this when it is
not enabled at runtime, see
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=804857#66

By default, without passing the nohz_full parameter, this behaves just
like NO_HZ_IDLE(default), enable it by passing nohz_full=all or nohz_full=cpulist, see
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/kernel/time/Kconfig?h=v6.6#n142
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/Documentation/admin-guide/kernel-parameters.rst?h=v6.6#n80

Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. 配置项重复添加

    • deepin_arm64_desktop_defconfigdeepin_loongarch_desktop_defconfigdeepin_x86_desktop_defconfig 文件中,CONFIG_NO_HZ_FULL=y 被重复添加了。建议检查是否有必要重复添加,或者确认是否是配置文件更新的一部分。
  2. 配置项的顺序

    • 配置项的顺序在配置文件中可能没有影响,但为了保持一致性,建议检查其他配置文件,确保 CONFIG_NO_HZ_FULL 的添加位置与其他配置项一致。
  3. 配置项的必要性

    • CONFIG_NO_HZ_FULL 是一个高级的内核配置选项,用于实现完全的内核态无延迟。在桌面环境中添加这个选项可能是因为需要更精确的时间控制,但需要确认是否有必要在所有这些配置文件中都启用它。
  4. 配置文件的一致性

    • 确保所有架构的桌面配置文件(deepin_arm64_desktop_defconfigdeepin_loongarch_desktop_defconfigdeepin_x86_desktop_defconfig)在配置项上保持一致,特别是那些新增的配置项。
  5. 文档和注释

    • 如果 CONFIG_NO_HZ_FULL 的添加是为了解决特定的问题或优化性能,建议在配置文件中添加相应的注释,说明为什么需要这个配置项,以及它的预期效果。
  6. 测试和验证

    • 在修改配置文件后,建议进行充分的测试,确保新增的配置项不会引入任何问题,并且能够按照预期工作。

综上所述,虽然这个提交本身没有明显的语法或逻辑错误,但建议进行进一步的确认和测试,以确保配置项的添加是必要的,并且不会对系统产生负面影响。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Avenger-285714
Copy link
Collaborator

/lgtm

@opsiff opsiff merged commit 9e132cb into linux-6.6.y Jan 7, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants