Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scsi: leapioraid: fix hiding ugood disk problem #535

Merged
merged 3 commits into from
Dec 27, 2024
Merged

scsi: leapioraid: fix hiding ugood disk problem #535

merged 3 commits into from
Dec 27, 2024

Conversation

leap-io
Copy link

@leap-io leap-io commented Dec 27, 2024

No description provided.

haodongdong and others added 3 commits December 12, 2024 16:46
scsi: leapioraid: supports LEAPIO RAID controller
c91a704 
This commit is to support LeapIO LEAPIO RAID controllers.
RAID controllers support RAID 0/1/5/6/10/50/60 modes;
RAID support SAS/SATA HDD/SSD.

Signed-off-by: haodongdong <doubled@leap-io.com>
@leap-io
Merge branch 'deepin-community:linux-6.6.y' into linux-6.6.y
ac27957
scsi: leapioraid: fix hiding ugood disk problem
931dac0 
fix hiding ugood disk problem.
fix "The address of local variable 'mpi_request' might be accessed at
non-zero index in function leapioraid_base_send_ioc_init"

Signed-off-by: haodongdong <doubled@leap-io.com>
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign avenger-285714 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见：

  1. 在leapioraid_func.c文件中，移除了对leapioraid_func.h的引用，但未在提交信息中说明原因。如果该引用不再需要，应确保移除所有相关的代码和注释，以保持代码的整洁。

  2. 在leapioraid_func.c文件中，leapioraid_debug_dump_mf函数被引入来替代原有的调试信息打印代码。这是一个改进，因为它提高了代码的可读性和可维护性。但是，需要确保leapioraid_debug_dump_mf函数的实现是正确的，并且已经通过了充分的测试。

  3. 在leapioraid_config_get_volume_handle函数中，当ioc_status等于LEAPIORAID_IOCSTATUS_CONFIG_INVALID_PAGE时，函数直接返回0，并将*volume_handle设置为0。这是一个合理的处理方式，因为它避免了在配置页无效时继续执行后续的代码。但是，应该确保这种处理方式与预期的业务逻辑一致，并且已经考虑了所有可能的错误情况。

  4. 在leapioraid_func.h文件中，LEAPIORAID_NAME_LENGTH的值从32增加到48。这个改动可能会影响到依赖于该宏的其他代码部分。需要检查所有相关的代码，确保它们能够正确处理新的名称长度，并且没有引入任何兼容性问题。

  5. 提交信息中应包含对代码更改的详细说明，包括为什么进行这些更改，以及这些更改如何影响现有代码和功能。这有助于其他开发者理解代码的上下文和目的。

总体来说，这些更改提高了代码的可读性和可维护性，但需要确保所有相关的代码都已经过充分的测试，并且与预期的业务逻辑一致。

@Avenger-285714
Copy link
Collaborator

测试通过

@Avenger-285714 Avenger-285714 merged commit 6c723fe into deepin-community:linux-6.6.y Dec 27, 2024
4 of 5 checks passed
@MingcongBai MingcongBai mentioned this pull request Jan 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wenlp Wenlp Awaiting requested review from Wenlp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leap-io @deepin-ci-robot @Avenger-285714