Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: phy: fix may not suspend when phy has WoL and not attached to ne… #430

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

opsiff
Copy link
Member

@opsiff opsiff commented Sep 23, 2024

…tdev

move code to compat this case.

…tdev

move code to compat this case.

Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • mdio_bus_phy_may_suspend函数中,新增代码块没有考虑到phydev可能为空的情况,应该添加对phydev的空检查。
  • phy_ethtool_get_wol函数的调用应该在if语句块中,以避免在phydev为空时执行该函数。
  • phydev_warn函数调用时缺少注释说明,应该添加注释说明其用途。
  • 新增代码中的注释应该遵循项目中的注释风格,例如使用多行注释或行内注释。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@opsiff opsiff merged commit d8c3b60 into linux-6.6.y Sep 23, 2024
5 of 10 checks passed
@opsiff opsiff deleted the opsiff-patch-phywol branch October 17, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants