Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deepin Kernel SIG] x86/cpu: Clarify the error message when BIOS does not support SGX #423

Merged

Conversation

Avenger-285714
Copy link
Collaborator

[ Upstream commit 7678a53a1688e3d03337ca884b284c6e7b060ec5 ]

When SGX is not supported by the BIOS, the kernel log contains the error 'SGX disabled by BIOS', which can be confusing since there might not be an SGX-related option in the BIOS settings.

For the kernel it's difficult to distinguish between the BIOS not supporting SGX and the BIOS supporting SGX but having it disabled.

Therefore, update the error message to 'SGX disabled or unsupported by BIOS' to make it easier for those reading kernel logs to understand what's happening.

Reported-by: Bo Wu wubo@uniontech.com
Co-developed-by: Zelong Xiang xiangzelong@uniontech.com
Signed-off-by: Zelong Xiang xiangzelong@uniontech.com
Signed-off-by: WangYuli wangyuli@uniontech.com
Signed-off-by: Thomas Gleixner tglx@linutronix.de
Acked-by: Kai Huang kai.huang@intel.com
Link: https://lore.kernel.org/all/F8D977CB368423F3+20240825104653.1294624-1-wangyuli@uniontech.com Closes: linuxdeepin/developer-center#10032 [ Backport from v6.12-rc1 ]

[ Upstream commit 7678a53a1688e3d03337ca884b284c6e7b060ec5 ]

When SGX is not supported by the BIOS, the kernel log contains the error
'SGX disabled by BIOS', which can be confusing since there might not be an
SGX-related option in the BIOS settings.

For the kernel it's difficult to distinguish between the BIOS not
supporting SGX and the BIOS supporting SGX but having it disabled.

Therefore, update the error message to 'SGX disabled or unsupported by
BIOS' to make it easier for those reading kernel logs to understand what's
happening.

Reported-by: Bo Wu <wubo@uniontech.com>
Co-developed-by: Zelong Xiang <xiangzelong@uniontech.com>
Signed-off-by: Zelong Xiang <xiangzelong@uniontech.com>
Signed-off-by: WangYuli <wangyuli@uniontech.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Kai Huang <kai.huang@intel.com>
Link: https://lore.kernel.org/all/F8D977CB368423F3+20240825104653.1294624-1-wangyuli@uniontech.com
Closes: linuxdeepin/developer-center#10032
[ Backport from v6.12-rc1 ]
@Avenger-285714 Avenger-285714 merged commit a32b611 into deepin-community:linux-6.6.y Sep 18, 2024
3 of 5 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from avenger-285714. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码中没有发现明显的语法或逻辑错误。
  • 修改了错误消息,以更准确地反映SGX功能被禁用的原因。

是否建议立即修改:

  • 否,因为提交的代码没有引入新的问题,且对现有代码的功能没有影响。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants